Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure pkg target is alive as long as needed #795

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Make sure pkg target is alive as long as needed #795

merged 3 commits into from
Apr 24, 2019

Conversation

shundhammer
Copy link
Contributor

Trello

https://trello.com/c/gjV8SydY

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1128385#c4
(the "reopen" case starting at comment #4)

Failing openQA Tests

https://openqa.opensuse.org/tests/913479
https://openqa.opensuse.org/tests/913480

Problem

No autologin even with a full-fledged KDE Plasma or GNOME desktop.

Cause

Pkg target already shut down (Pkg::TargetFinish), i.e. no packages known to libzypp on the target system, i.e. also no display manager that supports autologin, so no autologin configuration is written.

Fix

Change the order in inst_finish.rb: Make sure pkg is after users.

Test

Manual test with the ISO from the OpenQA test case plus the changed inst_finish.rb bind-mounted.

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM 😜

@shundhammer shundhammer merged commit aa816f1 into yast:master Apr 24, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.686% when pulling 9746c90 on shundhammer:huha-finish-pkg-last into ced2966 on yast:master.

@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #55 successfully finished
✔️ Created OBS submit request #697519

@shundhammer shundhammer deleted the huha-finish-pkg-last branch April 24, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants