Support for the online installation medium (jsc#SLE-7214) #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Sep 20, 2019
| require "fileutils" | ||
| require "pp" |
There was a problem hiding this comment.
To better format the logged data:
log.info "Found base products in the control.xml: #{@available_base_products.pretty_inspect}"
jreidinger
reviewed
Sep 20, 2019
| @@ -79,6 +86,10 @@ def registered? | |||
| rescue LoadError | |||
| false | |||
| end | |||
|
|
|||
| def product_id(prod) | |||
There was a problem hiding this comment.
hmm, can we extend prod to provide this method? For me it does not belong here, but to prod object itself.
There was a problem hiding this comment.
It's actually a widget ID, it not related to the products at all, it's used for identifying the RadioButton widgets. So I'd leave it here. I just renamed it to widget_id to make it clear.
There was a problem hiding this comment.
ah, with "widget_id" it fails, that's already used by CWM, renaming to "item_id"...
jreidinger
approved these changes
Sep 20, 2019
jreidinger
approved these changes
Sep 20, 2019
|
✔️ Public Jenkins job #69 successfully finished |
|
✔️ Internal Jenkins job #10 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
control.xmlfile