Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security upgrade #923

Merged
merged 3 commits into from Mar 2, 2021
Merged

Security upgrade #923

merged 3 commits into from Mar 2, 2021

Conversation

jreidinger
Copy link
Member

@coveralls
Copy link

coveralls commented Mar 2, 2021 •
edited

Coverage Status

Coverage increased (+0.006%) to 40.439% when pulling 3f41c67 on security_upgrade into 7c19909 on master.

@jreidinger jreidinger mentioned this pull request Mar 2, 2021
Closed
dgdavid
dgdavid approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, although I miss some unit testing here. Could you please add it before merging it?

dgdavid
dgdavid approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit ff95270 into master Mar 2, 2021
@jreidinger jreidinger deleted the security_upgrade branch March 2, 2021 15:14
@yast-bot
Copy link
Contributor

yast-bot commented Mar 2, 2021

✔️ Internal Jenkins job #71 successfully finished
✔️ Created IBS submit request #237021

@yast-bot
Copy link
Contributor

yast-bot commented Mar 2, 2021

✔️ Public Jenkins job #146 successfully finished
✔️ Created OBS submit request #876260

This was referenced Mar 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jreidinger @coveralls @yast-bot @dgdavid