Remove useless udevadm calls from kernel_finish client #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
rm_kernel_udevadm
branch
from
d3d8c99
to
4ae1e8b
Compare
jreidinger
approved these changes
Mar 10, 2021
|
✔️ Public Jenkins job #149 successfully finished |
|
✔️ Internal Jenkins job #74 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The kernel_finish client does some udevadm calls from the target system (chroot) which do not have any effect at all.
Solution
Remove unnecessary calls from kernel_finish as since /dev and /run are shared and since (systemd/systemd#11346) them are completely useless.