Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ::Users::UsersDatabase call #968

Merged
merged 3 commits into from Jun 16, 2021
Merged

Fix ::Users::UsersDatabase call #968

merged 3 commits into from Jun 16, 2021

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Jun 16, 2021

For some reason, the scope resolution operator in ::Users::UsersDatabase
was forgotten/omitted in #371, but it is needed to avoid resolving to Yast::Users::UsersDatabase.

@dgdavid
Reference the global namespace for calling Users::UsersDatabase
a7f85d3 
For some reason, the scope resolution operator in ::Users::UsersDatabase
was forgotten/omitted in #371,
but it is needed to avoid resolving to Yast::Users::UsersDatabase.
@dgdavid
Bump version and update changelog
9385d41
@dgdavid

This comment has been minimized.

Sign in to view
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 39.519% when pulling f926f1e on fix-usersdatabase-call into 5020e86 on master.

@dgdavid

This comment has been minimized.

Sign in to view
ancorgs
ancorgs approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgdavid dgdavid merged commit 369c846 into master Jun 16, 2021
@dgdavid dgdavid deleted the fix-usersdatabase-call branch June 16, 2021 12:32
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #174 successfully finished
✔️ Created OBS submit request #900373

@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #81 failed

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #82 successfully finished
✔️ Created IBS submit request #243837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

@joseivanlopez joseivanlopez joseivanlopez approved these changes

@ancorgs ancorgs ancorgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dgdavid @coveralls @yast-bot @jreidinger @joseivanlopez @ancorgs