simplify slide show and show release notes button #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a139b20. After checking it, it was declined as it is not better.
joseivanlopez
approved these changes
Jan 12, 2022
| else | ||
| SlideShow.SetReleaseNotes(InstData.release_notes, base_product_name) | ||
| end | ||
| # hide in ncurses release notes button as it block installation process if pressed |
There was a problem hiding this comment.
NP: I would rephrase a bit: "Hide release notes button in ncurses because it blocks the installation process"
|
✔️ Public Jenkins job #202 successfully finished |
|
✔️ Internal Jenkins job #110 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to yast/yast-packager#590 and yast/yast-yast2#1202