Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "BuildRequires: update-desktop-files" #45

Merged
merged 1 commit into from Jul 19, 2019
Merged

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jul 19, 2019

  • The recent fix in YaST RPM macros now updates the desktop files
  • The %suse_update_desktop_file macro is defined in the update-desktop-files package
  • Without it the macro is not expanded and the shell treats % as a job control character and fails with error fg: no job control

- Related to the previous desktop file changes (fate#319035)
- 4.2.2
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you so much for the fix!

@lslezak lslezak merged commit 99ca02a into master Jul 19, 2019
@lslezak lslezak deleted the update-desktop-files branch July 19, 2019 07:07
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #16 successfully finished
✔️ Created OBS submit request #716728

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #3 successfully finished
✔️ Created IBS submit request #197082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants