- enable Style/EmptyLines

.rubocop.yml

@@ -101,15 +101,6 @@ Style/EmptyLineBetweenDefs:
     - 'src/include/iscsi-client/widgets.rb'
     - 'src/modules/IscsiClientLib.rb'
 
-# Offense count: 20
-# Cop supports --auto-correct.
-Style/EmptyLines:
-  Exclude:
-    - 'src/include/iscsi-client/dialogs.rb'
-    - 'src/include/iscsi-client/widgets.rb'
-    - 'src/modules/IscsiClient.rb'
-    - 'src/modules/IscsiClientLib.rb'
-
 # Offense count: 7
 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
 Style/FileName:

src/include/iscsi-client/dialogs.rb

@@ -312,7 +312,6 @@ def initialize_iscsi_client_dialogs(include_target)
         }
       }
 
-
       @tabs_descr = {
         # service status dialog
         "general"    => {

src/include/iscsi-client/widgets.rb

@@ -279,7 +279,6 @@ def validateISNS(_key, event)
       true
     end
 
-
     def storeISNS(_key, event)
       event = deep_copy(event)
       address = Convert.to_string(UI.QueryWidget(:isns_address, :Value))
@@ -335,8 +334,6 @@ def storeISNS(_key, event)
       nil
     end
 
-
-
     def initInitName(_key)
       Builtins.y2milestone("initiatorname %1", IscsiClientLib.initiatorname)
       UI.ChangeWidget(:initiator_name, :Value, IscsiClientLib.initiatorname)
@@ -405,7 +402,6 @@ def validateInitName(_key, event)
       end
     end
 
-
     def storeInitName(_key, event)
       event = deep_copy(event)
       if Convert.to_string(UI.QueryWidget(:initiator_name, :Value)) !=
@@ -665,7 +661,6 @@ def validateServerLocation(_key, _event)
       @stat
     end
 
-
     # ********************* discovered table *******************
 
     # enable [ connect, delete ] buttons only for not connected items
@@ -849,7 +844,6 @@ def handleTargetTable(_key, event)
         UI.ChangeWidget(:connect, :Enabled, true)
       end
 
-
       if Ops.get_string(event, "EventReason", "") == "Activated"
         if Ops.get(event, "ID") == :connect
           # check if is not already connected

src/modules/IscsiClient.rb

@@ -97,7 +97,6 @@ def Modified
       @modified
     end
 
-
     # check if package open-iscsi is installed
     def installed_packages
       # don't check interactively for packages (bnc#367300)
@@ -119,8 +118,6 @@ def installed_packages
       ret
     end
 
-
-
     # Dump the iscsi-client settings to a single map
     # (For use by autoinstallation.)
     # @return [Hash] Dumped settings (later acceptable by Import ())
@@ -244,7 +241,6 @@ def Read
       true
     end
 
-
     # Write all iscsi-client settings
     # @return true on success
     def Write
@@ -316,7 +312,6 @@ def Import(settings)
       true
     end
 
-
     # Create a textual summary and a list of unconfigured cards
     # @return summary of the current configuration
     def Summary

src/modules/IscsiClientLib.rb

@@ -247,7 +247,6 @@ def getiBFT
       @ibft
     end
 
-
     # get accessor for service status
     def GetStartService
       status_d = socketEnabled?(@iscsid_socket)
@@ -273,7 +272,6 @@ def SetStartService(status)
       nil
     end
 
-
     # read configuration file
     def getConfig
       # use cache if available
@@ -311,7 +309,6 @@ def useISNS
       isns_info
     end
 
-
     # write temporary changed old config
     def oldConfig
       Builtins.y2milestone("Store temporary config %1", @config)
@@ -321,7 +318,6 @@ def oldConfig
       nil
     end
 
-
     def getNode
       cmdline = GetAdmCmd(
         Builtins.sformat(
@@ -745,7 +741,6 @@ def checkInitiatorName
       ret
     end
 
-
     # delete deiscovered target from database
     def deleteRecord
       ret = true
@@ -1007,7 +1002,6 @@ def autoLogOn
       ret
     end
 
-
     def loginIntoTarget(target)
       target = deep_copy(target)
       @currentRecord = [
@@ -1074,7 +1068,6 @@ def loginIntoTarget(target)
       true
     end
 
-
     # FIXME: this method has too much responsibility and it is doing
     # "unexpected" things according to its name. Ideally, it only must return
     # the service status without changing the status of related services and
@@ -1141,7 +1134,6 @@ def setServiceStatus
       ret
     end
 
-
     def autoyastPrepare
       @initiatorname = Ops.get_string(@ay_settings, "initiatorname", "")
       if Ops.greater_than(Builtins.size(@initiatorname), 0)