add log viewer class #30
Conversation
|
Hmm, instead of creating a completely different dialog. Wouldn't it be better to simply modify the existing So you have all the features (like real-time "grepping" or redefining the criteria) without having to maintain two different dialogs. |
|
@ancorgs to be honest I am not sure as basically mean change from trivial log reader to quite complex table with many attributes. Does it have at least reasonable help text? |
|
If the help text if not enough we can improve it and have a win-win situation. A more powerful log reader and a better help for the standalone yast-journal. :-) |
| def initialize | ||
| super | ||
| # @param query [QueryPresenter] optional initial query | ||
| def initialize(query: nil) |
There was a problem hiding this comment.
This is something that was probably a little bit weird already in the original implementation, receiving a QueryPresenter instead of a Query as argument.
It probably makes more sense to receive a Query and create the QueryPresenter to wrap it as part of EntriesDialog#initialize (which probably means touching the QueryPresenter API, as well, I know).
example/log_viewer.rb
Outdated
| params = Yast::WFM.Args | ||
| raise "missing param for log entries" if params.empty? | ||
|
|
||
| query = SystemdJournal::QueryPresenter.new(interval: "0", filters: { "unit" => params }) |
There was a problem hiding this comment.
See below. I would change the QueryPresenter API a bit to make possible to do something like this:
query = SystemdJournal::Query.new(interval: "0", filters: { "unit" => params })
SystemdJournal::EntriesDialog.new(query: query).runBecause having to provide a presenter object instead of the real thing to the dialog feels very weird.
|
|
||
| This directory allows to check how some UI will look into various circumstances. | ||
|
|
||
| As it use real systemd journal it have to be run as root. It is also recommended |
There was a problem hiding this comment.
Strictly speaking, journalctl can also be run as normal user, although it will show very limited records.
| dates = { | ||
| since: Yast::Builtins.strftime(interval[:since], TIME_FORMAT), | ||
| until: Yast::Builtins.strftime(interval[:until], TIME_FORMAT) | ||
| } | ||
| _("Between %{since} and %{until}") % dates | ||
| when nil |
There was a problem hiding this comment.
The possibility of passing nil if not so clear in the yardoc documentation of SystemdJournal::Query#initialize. We should likely take the opportunity to improve it.
There was a problem hiding this comment.
@ancorgs well, issue is that it is default value. So it is a bit strange situation.
related to https://bugzilla.suse.com/show_bug.cgi?id=1008493
how looks example on TW: