Kdump for xen #75
Merged
Kdump for xen #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
requested changes
Mar 29, 2017
src/modules/Kdump.rb
Outdated
| @@ -920,8 +943,11 @@ def filterExport(settings) | |||
| def Export | |||
| crash_kernel = crash_kernel_values | |||
| crash_kernel = crash_kernel[0] if crash_kernel.size == 1 | |||
| crash_xen_kernel = crash_kernel_values | |||
src/autoyast-rnc/kdump.rnc
Outdated
| @@ -6,11 +6,14 @@ namespace config = "http://www.suse.com/1.0/configns" | |||
| kdump = | |||
| element kdump { | |||
| (kdump_crash_kernel_value | kdump_crash_kernel_list)? & | |||
| # parameter specify crashkernel value for xen hypervisor | |||
| kdump_crash_xen_value? & | |||
There was a problem hiding this comment.
This needs to mimic the above line because Export uses either an array or a single string too.
There was a problem hiding this comment.
done, thanks for notice.
jreidinger
commented
Mar 29, 2017
src/modules/Kdump.rb
Outdated
| @@ -487,6 +509,7 @@ def WriteKdumpBootParameter | |||
| if @crashkernel_param | |||
| #delete crashkernel parameter from bootloader | |||
| Bootloader.modify_kernel_params(:common, :xen_guest, :recovery, "crashkernel" => :missing) | |||
| Bootloader.modify_kernel_params(:common, :xen_host, :recovery, "crashkernel" => :missing) | |||
There was a problem hiding this comment.
typo here, only :xen_host should be written.
There was a problem hiding this comment.
just note it is harmless, as it is done one line up, so I merge it.
mvidner
reviewed
Mar 29, 2017
src/autoyast-rnc/kdump.rnc
Outdated
| @@ -6,15 +6,22 @@ namespace config = "http://www.suse.com/1.0/configns" | |||
| kdump = | |||
| element kdump { | |||
| (kdump_crash_kernel_value | kdump_crash_kernel_list)? & | |||
| # parameter specify crashkernel value for xen hypervisor | |||
| (kdump_crash_xen_value | kdump_crash_xen_kernel_list)? & | |||
|
The good news is that the tests have finally run... |
mvidner
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.