Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing tests in OBS build #12

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Fixed failing tests in OBS build #12

merged 1 commit into from
Mar 28, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Mar 28, 2022

Problem

Solution

  • Fixed unit tests
  • Additionally added mock for obtaining the registration URL which runs a SLP server scan, that's not nice to run for real in the tests

Notes

  • No version bump as the package was not released yet (failed in Jenkins)

@lslezak lslezak merged commit 1132086 into master Mar 28, 2022
@yast-bot
Copy link

✔️ Public Jenkins job #2 successfully finished
✔️ Created OBS submit request #965419

@lslezak lslezak deleted the build-fix branch March 28, 2022 14:32
@coveralls
Copy link

coveralls commented Mar 28, 2022

Pull Request Test Coverage Report for Build 2052740692

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.281%

Totals Coverage Status
Change from base Build 2051048093: 0.0%
Covered Lines: 106
Relevant Lines: 153

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants