Provide icon with module (boo#1109310) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
reviewed
Nov 28, 2018
| @@ -0,0 +1,36 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
The yast2-migration package migrates the installed product to a newer service pack level, e.g. SLES12 SP1 to SLES12 SP2 (or newer if available).
For me the icon more suggest migrating (cloning) the installed system to somewhere else.
I think replacing the hard drive icon with a CD/DVD icon would be better. Or you could even use a package symbol as in reality the migration uses remote HTTP repositories, not physical CD/DVD media.
There was a problem hiding this comment.
Maybe something similar or even the same as in yast-upgrade.svg could be OK.
|
✔️ Internal Jenkins job #4 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.