Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fix #45

Merged
merged 4 commits into from Nov 29, 2018
Merged

Build fix #45

merged 4 commits into from Nov 29, 2018

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Nov 29, 2018

  • The icon method has been removed from the parent class, remove the test as well
  • Fixed an RSpec warning, make the check less strict:
WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect
  • Fixed evaluating the code coverage, it did not count the src/clients/* files so the reported coverage was a bit higher than in reality. So the coverage drop is actually expected, we are no longer cheating here. 馃槤

The "icon" method has been removed from the parent test
WARNING: `allow(...).to receive(..).ordered` is not supported and will have no effect
4.1.1
@coveralls
Copy link

coveralls commented Nov 29, 2018

Coverage Status

Coverage decreased (-14.005%) to 85.995% when pulling 5a4a217 on build_fix into ba998fc on master.

Copy link
Member

@aschnell aschnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 1079d57 into master Nov 29, 2018
@lslezak lslezak deleted the build_fix branch November 29, 2018 09:50
@yast-bot
Copy link

鉁旓笍 Internal Jenkins job #5 successfully finished
鉁旓笍 Created IBS submit request #178744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants