Added command line support for Active Slave sync #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsuchome you are still mentioned as maintainer of this module, so if you could check it. Thanks |
|
|
||
| if Ops.get_string(options, "sync_slave", "") != "" | ||
| NisServer.nopush = Ops.get_string(options, "sync_slave", "") == "yes" | ||
| end | ||
|
|
There was a problem hiding this comment.
No need to use get_string here. Just options["sync_slave"]
There was a problem hiding this comment.
Yeah, just Option["sysc_slave"] would be a slim version, But I guess the get_string just go with flow of the code very well. let me know, both seems to be nice.
if Options["sync_slave", ""] != ""
NisServer.nopush = Options["sync_slave", ""] == "yes"
end
|
@ashish1099 hi, what is status here? I do not see changes for @jsuchome concerns |
|
I will update on this |
|
@ashish1099 still no update. please reopen when it is updated, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to setup master/slave nis server, but there was no command line option for me to enable the "Active Slave NIS server exists".
If we don't enable this the data is not pushed from master to slave server, and same has said in the docs.
So this patch works great. hopping to see in next update.