Conf name #108
Conf name #108
Conversation
src/modules/NtpClient.rb
Outdated
| @@ -35,6 +35,9 @@ class NtpClientClass < Module | |||
|
|
|||
| NTP_FILE = "/etc/chrony.conf".freeze | |||
|
|
|||
| # The cron file name for the synchronization. | |||
| CRON_FILE = "/etc/cron.d/suse-ntp_synchronize" | |||
There was a problem hiding this comment.
Just add the call to #freeze.
|
👮 Rubocop complains... |
|
manual testing of RPM upgrade works well, so I will pleasure rubocop and add changes |
package/yast2-ntp-client.changes
Outdated
| (bsc#1079122) | ||
| - convert old file to new one during upgrade, ensure that ntpd is | ||
| replaced by chrony (FATE#323432) | ||
| - ghost that config file, so it is easy to find who own it |
There was a problem hiding this comment.
"who own it" or "which package owns it" ?
There was a problem hiding this comment.
or "which package belongs to" ?
src/modules/NtpClient.rb
Outdated
| "-*/#{@sync_interval} * * * * root /usr/sbin/chronyd -q &>/dev/null\n" | ||
| ) | ||
| else | ||
| SCR.Execute( | ||
| path(".target.bash"), | ||
| "test -e #{@cron_file} && rm #{@cron_file};" | ||
| "test -e #{CRON_FILE} && rm #{CRON_FILE};" |
There was a problem hiding this comment.
NP: there is a trailing ; and maybe simple rm -f #{CRON_FILE} (without the test) would be better (even could be replaced by native Ruby)
| @@ -812,13 +812,13 @@ def update_cron_settings | |||
| if @synchronize_time | |||
| SCR.Write( | |||
| path(".target.string"), | |||
| @cron_file, | |||
| CRON_FILE, | |||
There was a problem hiding this comment.
Just an idea, ... but probably too late: Could we have a comment here (in file) that this is created by us and that the user should run YaST to re/configure it?
There was a problem hiding this comment.
yes, such comment probably makes good sense. This one is already merged, but I can open new one.
No description provided.