Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netconfit path #175

Merged
merged 2 commits into from Nov 21, 2022
Merged

Fix netconfit path #175

merged 2 commits into from Nov 21, 2022

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Nov 21, 2022

Problem

In #174 we fixed a Tumbleweed bug avoiding to call netconfig when it was not present in the system but as consequence of that bug the executable is probably not called anymore in SLE-15-SP5 as we modified the full path of the executable to be /usr/sbin/netconfig which is wrong as it should be /sbin/netconfig.

Solution

Fix the netconfig full path in SLE-15-SP5 by now although we should look for a better solution in order to not use full paths anymore avoiding these kinds of problems (usr-merge).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.778% when pulling 47474f5 on fix_netconfit_path into 49179e0 on master.

Copy link
Contributor

@shundhammer shundhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit 99c8e0e into master Nov 21, 2022
@teclator teclator deleted the fix_netconfit_path branch November 21, 2022 15:11
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #48 successfully finished
✔️ Created OBS submit request #1037135

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #30 successfully finished
✔️ Created IBS submit request #284781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants