Merge a600a56 into 8510657

.github/workflows/ci.yml

@@ -0,0 +1,79 @@
+
+# See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  Tests:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    # FIXME: optionally install the missing dependencies
+    # - name: Install Dependencies
+    #   run: zypper --non-interactive install foobar
+
+    # just for easier debugging...
+    - name: Inspect Installed Packages
+      run: rpm -qa | sort
+
+    - name: Unit Tests
+      run: rake test:unit
+      # enable code coverage reporting
+      env:
+        COVERAGE: 1
+
+    # send the coverage report to coveralls.io
+    - name: Coveralls Report
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+
+  Package:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: Package Build
+      run: yast-ci-ruby -o package
+
+  Yardoc:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: Yardoc
+      # FIXME: you can just run "yardoc" if "check:doc" task is too strict...
+      run: rake check:doc
+
+  # downloading the Docker image takes some time so bundling several fast
+  # checks into one job avoids that overhead
+  Checks:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: POT Check
+      run: rake check:pot
+
+    # FIXME: Fix all warnings found by shell check
+    #- name: Shell Check
+    #  run: shellcheck src/bin/online_update

README.md

@@ -1,5 +1,8 @@
 # YaST - The Online Update Configuration #
 
-[![Travis Build](https://travis-ci.org/yast/yast-online-update-configuration.svg?branch=master)](https://travis-ci.org/yast/yast-online-update-configuration)
-[![Jenkins Build](http://img.shields.io/jenkins/s/https/ci.opensuse.org/yast-online-update-configuration-master.svg)](https://ci.opensuse.org/view/Yast/job/yast-online-update-configuration-master/)
-
+[![Workflow Status](https://github.com/yast/yast-online-update-configuration/workflows/CI/badge.svg?branch=master)](
+https://github.com/yast/yast-online-update-configuration/actions?query=branch%3Amaster)
+[![Jenkins Status](https://ci.opensuse.org/buildStatus/icon?job=yast-yast-online-update-configuration-master)](
+https://ci.opensuse.org/view/Yast/job/yast-yast-online-update-configuration-master/)
+[![Coverage Status](https://img.shields.io/coveralls/yast/yast-online-update-configuration.svg)](https://coveralls.io/r/yast/yast-online-update-configuration?branch=master)
+[![inline docs](http://inch-ci.org/github/yast/yast-online-update-configuration.svg?branch=master)](http://inch-ci.org/github/yast/yast-online-update-configuration)

src/modules/OnlineUpdateConfiguration.rb

@@ -453,8 +453,8 @@ def removeOnlineUpdateCronjobs
     end
 
     # setup cronjob for an automatic online update
+    # @param interval [Symbol] for the interval `daily, `weekly, `monthly
     # @return true if successful
-    # @para smybol for the interval `daily, `weekly, `monthly
     def setOnlineUpdateCronjob(interval)
       cronSel = ""
       if interval == :monthly

test/test_helper.rb

@@ -4,3 +4,42 @@
 
 require 'yast'
 require 'online-update-configuration/zypp_config'
+
+RSpec.configure do |config|
+  config.mock_with :rspec do |mocks|
+    # If you misremember a method name both in code and in tests,
+    # will save you.
+    # https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles
+    #
+    # With graceful degradation for RSpec 2
+    mocks.verify_partial_doubles = true if mocks.respond_to?(:verify_partial_doubles=)
+  end
+end
+
+if ENV["COVERAGE"]
+  require "simplecov"
+  SimpleCov.start do
+    add_filter "/test/"
+  end
+
+  src_location = File.expand_path("../src", __dir__)
+  # track all ruby files under src
+  SimpleCov.track_files("#{src_location}/**/*.rb")
+
+  # additionally use the LCOV format for on-line code coverage reporting at CI
+  if ENV["CI"] || ENV["COVERAGE_LCOV"]
+    require "simplecov-lcov"
+
+    SimpleCov::Formatter::LcovFormatter.config do |c|
+      c.report_with_single_file = true
+      # this is the default Coveralls GitHub Action location
+      # https://github.com/marketplace/actions/coveralls-github-action
+      c.single_report_path = "coverage/lcov.info"
+    end
+
+    SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+      SimpleCov::Formatter::HTMLFormatter,
+      SimpleCov::Formatter::LcovFormatter
+    ]
+  end
+end