Skip to content

Commit

Permalink
improve the progress bar during package installation slideshow
Browse files Browse the repository at this point in the history
(bnc#831875, port from SLE11 bnc#724486)

see commit 2be99dd
  • Loading branch information
lslezak committed Sep 3, 2013
1 parent e9f8b4e commit 5f3ffa1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions package/yast2-packager.changes
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Tue Sep 3 11:34:48 UTC 2013 - lslezak@suse.cz
proposed packages - i.e. add snapper packages after switching to
btrfs (bnc#831875, port from SLE11 bnc#704127) (see commit
6c48fd7761)
- improve the progress bar during package installation slideshow
(bnc#831875, port from SLE11 bnc#724486) (see commit 2be99dd9ff)

-------------------------------------------------------------------
Tue Sep 3 12:31:37 CEST 2013 - jsuchome@suse.cz
Expand Down
4 changes: 3 additions & 1 deletion src/modules/PackageSlideShow.rb
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,9 @@ def packages_to_download(src_mapping)
Ops.get_string(URL.Parse(repo_url), "scheme", "")
)

if Builtins.contains(["http", "https", "ftp", "sftp"], repo_schema)
# iso repos get also downloaded according to experience; the addition is not a perfect
# fix, but still improves the progress (bnc#724486)
if Builtins.contains(["http", "https", "ftp", "sftp", "iso"], repo_schema)
total = 0
Builtins.foreach(media_mapping) do |count|
total = Ops.add(total, count)
Expand Down

3 comments on commit 5f3ffa1

@jreidinger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well. maybe you can make it more ruby like

schemas_with_progress = ["http", "https", "ftp", "sftp", "iso"]
if schemas_with_progress.include? repo_schema
...

@lslezak
Copy link
Member Author

@lslezak lslezak commented on 5f3ffa1 Sep 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was focused just on porting the fixes, I didn't want to make the review harder with additional refactoring...

Please sign in to comment.