Merge pull request #548 from yast/fix_patterns

Fix patterns

package/yast2-packager.changes

@@ -1,3 +1,11 @@
+-------------------------------------------------------------------
+Fri Feb 12 20:38:23 UTC 2021 - Josef Reidinger <jreidinger@suse.com>
+
+- Fix crash when installation proposal require pattern and such
+  pattern is not available in any repository (found during testing
+  jsc#SLE-17427)
+- 4.2.68
+
 -------------------------------------------------------------------
 Tue Dec  1 15:03:41 UTC 2020 - Josef Reidinger <jreidinger@suse.com>
 

package/yast2-packager.spec

@@ -17,7 +17,7 @@
 
 
 Name:           yast2-packager
-Version:        4.2.67
+Version:        4.2.68
 Release:        0
 Summary:        YaST2 - Package Library
 License:        GPL-2.0-or-later

src/modules/Packages.rb

@@ -2540,7 +2540,7 @@ def check_missing_resolvables
 
           missing[type] = [] unless missing[type]
           # use quoted "summary" value for patterns as they usually contain spaces
-          name = (type == :pattern) ? statuses.first.summary.inspect : item
+          name = (type == :pattern && !statuses.empty?) ? statuses.first.summary.inspect : item
           missing[type] << name
         end
       end

test/packages_test.rb

@@ -1856,4 +1856,15 @@ def expect_source_urls(mapping)
       end
     end
   end
+
+  describe "#check_missing_resolvables" do
+    it "does not crash for non available pattern" do
+      allow(Yast::PackagesProposal).to receive(:GetAllResolvablesForAllTypes)
+        .and_return(pattern: ["non-existing"])
+      allow(Y2Packager::Resolvable).to receive(:find).with(kind: :pattern, name: "non-existing")
+        .and_return([])
+
+      expect(subject.send(:check_missing_resolvables)).to eq(pattern: ["non-existing"])
+    end
+  end
 end