Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double encode #189

Merged
merged 3 commits into from Oct 4, 2016
Merged

Double encode #189

merged 3 commits into from Oct 4, 2016

Conversation

jreidinger
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 34.907% when pulling 8b84cec on double_encode into f0fe440 on master.

lslezak
lslezak requested changes Oct 3, 2016
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an unit test for this fix. There are already some unit tests for the PostprocessISOURL method here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 34.917% when pulling 85aeff3 on double_encode into f0fe440 on master.

lslezak
lslezak approved these changes Oct 4, 2016
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit 73a42bd into master Oct 4, 2016
@jreidinger jreidinger deleted the double_encode branch October 4, 2016 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jreidinger @coveralls @lslezak