Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic solution for the YaST needed packages (bsc#885496) #204

Merged
merged 3 commits into from
Nov 14, 2016

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Nov 14, 2016

Description

This is a generic solution for checking the packages/patterns required by YaST itself. See the original bug report for the bootloader module.

Currently only the bootloader module checks for unselected packages, this is a generic solution for all YaST modules. (The bootloader specific part will be removed after merging this PR.)

Screenshots

The proposal contains an error message with list of missing packages or patterns if user deselects some needed items:

packages_proposal

After clicking the Install button the installation is blocked, user must resolve the problem either by selecting the packages back or by adjusting the respective YaST configuration (e.g. do not install any bootloader and disable the firewall).

packages_proposal2

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e00f78a on check_needed_packages into * on master*.

@lslezak lslezak changed the title [WIP] Generic solution for the YaST needed packages (bsc#885496) Generic solution for the YaST needed packages (bsc#885496) Nov 14, 2016
@jreidinger
Copy link
Member

well, one usability not, if would be nice to write which component need given packages ( packages should have it )

@jreidinger
Copy link
Member

LGTM, if you tested it properly manually ;)

@lslezak
Copy link
Member Author

lslezak commented Nov 14, 2016

Yes, I thought about improving the usability. Unfortunately the component is only identified by an unique ID which might but might not refer to some YaST module. In reality it is:

{
  "storage_proposal" => {:package => ["btrfsprogs", "e2fsprogs", "snapper"]},
  "DefaultDesktopPatterns" => {:pattern => ["kde", "x11", "base"]},
  "yast2-bootloader" => {:package => ["kexec-tools", "grub2", "syslinux"]}
}

That means you cannot easily say what the user need to do or which YaST configuration needs to be changed.

And for example storage or the desktop pattern are selected before entering the proposal, you need to go back to change them.

@lslezak lslezak merged commit 93d41b2 into master Nov 14, 2016
@lslezak lslezak deleted the check_needed_packages branch November 14, 2016 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants