bsc#1157780: improve addon selector #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
reviewed
Feb 28, 2020
|
for me change looks fine. |
|
✔️ Internal Jenkins job #50 successfully finished |
|
✔️ Public Jenkins job #113 successfully finished |
This was referenced Mar 6, 2020
dgdavid
added a commit
to yast/yast-registration
that referenced
this pull request
Mar 13, 2020
For consistence with the behavior introduced in yast2-packager 4.2.55 See yast/yast-packager#511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the discussion about yast/yast-registration#483 is taking some time, we have decided to propose this alternative fix until the new widget is ready. Bear in mind that the new widget will bring other improvements, but this PR should at least fix the bug described in bsc#1157780 (although it changes the behaviour). Let's consider this a Plan B :)
In a nutshell, the idea is to consider the first available product as the current one (although it is not selected) and display its information. See the screenshots below and read on to find further information.
Addon selection in Qt
Addon selection in ncurses
The problem
The selector widget considers the first element as the current one. So if the user clicks in the first element to see the details, the widget will not propagate that event (in reality, the value has not changed).