[SP3] Display repository alias if the repository name is not defined (bsc#1184935)

[lslezak]

The Problem

• https://bugzilla.suse.com/show_bug.cgi?id=1184935
• When editing a repository in the YaST repository manager in some cases the repository name field is empty.

Background

Libzypp (or the reused Yum file format) actually uses two names for repositories:

• alias - This is the mandatory repository identifier, it should be a short string identifying the repository. It must be unique and some characters are not allowed there (/ is automatically replaced because the alias is also used as the .repo file name). YaST never displays the alias as this is kind of internal data.
• name - This is the user visible name, it is optional (might be missing) and it might not be unique (duplicates are allowed), it can contain any arbitrary text, no limit for allowed characters. This is what YaST displays.

The name can contain some variables like $releasever which is replaced by the installed product version. So the openSUSE $releasever name gets expanded to openSUSE 15.3 in Leap 15.3. It is possible to get both values from libzypp, the expanded one (via the name() method) and the unexpanded original (using the rawName() method).

Debugging

Originally I was able to reproduce the problem in some previous Tumbleweed release. It behaved strangely, for some repositories the name was displayed correctly, for some it was just empty.

Later I could not reproduce the problem it with the latest TW, but luckily the problem happens on my older Leap workstation.

Details

I was able to reproduce the problem locally with some testing repository I used in the past. The /etc/zypp/repos.d/test.repo contained:

[test]
enabled=0
autorefresh=1
baseurl=dir:/local/work/test
type=yast2
keeppackages=0

As you can see the name attribute is actually missing there!

It turned out that the name() method fallbacks to the repository alias in libzypp if the name is not defined. But the rawName() method does not use any fallback, if the name is not defined it returns empty string.

And YaST (as an exception) displays the raw name in that dialog to allow editing the variables in the name...

The Fix

To fix the problem YaST should display the name if the raw name is empty, in that case the name contains the alias as a fallback. That's also what YaST and zypper show as the repository name in that case.

Testing

Just tested manually with that repository mentioned above, the name (actually the alias fallback) is displayed correctly:

[teclator]

LGTM

[coveralls]

Coverage decreased (-0.006%) to 35.273% when pulling 067d1ab on repo_name_sp3 into dcda2c7 on SLE-15-SP3.

[jreidinger]

Is possible to have a test case or is it too hard?

[lslezak]

Unfortunately this is an old YCP code with a 500+ lines method.... 😟

[lslezak]

Submitted manually in https://build.suse.de/request/show/243398

[yast-bot]

✔️ Internal Jenkins job #1 successfully finished