Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set the custom repository name (#1191491) #594

Merged
merged 2 commits into from Dec 2, 2021
Merged

Properly set the custom repository name (#1191491) #594

merged 2 commits into from Dec 2, 2021

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Nov 26, 2021

  • https://bugzilla.suse.com/show_bug.cgi?id=1191491
  • Use the user provided name for a new repository
  • Just pass the preferred_name to the method which creates the product definition
  • Simplified URL path parsing, unescape the path (e.g. convert %20 to spaces)
  • Added unit test

@coveralls
Copy link

coveralls commented Nov 26, 2021 •
edited

Coverage Status

Coverage increased (+0.02%) to 36.79% when pulling 5166ae3 on repo_name2 into d0568db on master.

@lslezak lslezak mentioned this pull request Nov 26, 2021
Merged
@lslezak lslezak merged commit ae536e5 into master Dec 2, 2021
@lslezak lslezak deleted the repo_name2 branch December 2, 2021 13:01
@yast-bot
Copy link
Contributor

yast-bot commented Dec 2, 2021

✔️ Public Jenkins job #167 successfully finished
✔️ Created OBS submit request #935177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @jreidinger