Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rubocop #598

Merged
merged 17 commits into from Jan 13, 2022
Merged

New rubocop #598

merged 17 commits into from Jan 13, 2022

Conversation

jreidinger
Copy link
Member

No description provided.

lslezak
lslezak reviewed Jan 12, 2022
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and comments

src/clients/sw_single.rb Outdated Show resolved Hide resolved
src/lib/y2packager/clients/inst_productsources.rb Show resolved Hide resolved
src/lib/y2packager/widgets/simple_language_selection.rb Outdated Show resolved Hide resolved
src/modules/Packages.rb Outdated Show resolved Hide resolved
src/modules/SourceDialogs.rb Show resolved Hide resolved
src/modules/SourceDialogs.rb Outdated Show resolved Hide resolved
src/modules/SpaceCalculation.rb Outdated Show resolved Hide resolved
test/packages_test.rb Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 12, 2022 •
edited

Coverage Status

Coverage increased (+0.3%) to 36.757% when pulling 7a0498c on new_rubocop into 52904e9 on master.

@jreidinger jreidinger merged commit bff0d8b into master Jan 13, 2022
@jreidinger jreidinger deleted the new_rubocop branch January 13, 2022 21:41
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #173 successfully finished
✔️ Created OBS submit request #946231

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #99 successfully finished
✔️ Created IBS submit request #262177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jreidinger @coveralls @yast-bot @lslezak