Merge pull request #39 from yast/github_actions

GitHub actions

.github/workflows/ci.yml

@@ -0,0 +1,82 @@
+
+# See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
+
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  Tests:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    # just for easier debugging...
+    - name: Inspect Installed Packages
+      run: rpm -qa | sort
+
+    - name: Unit Tests
+      run: rake test:unit
+      # enable code coverage reporting
+      env:
+        COVERAGE: 1
+
+    # send the coverage report to coveralls.io
+    - name: Coveralls Report
+      uses: coverallsapp/github-action@master
+      with:
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+
+  Rubocop:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: Rubocop
+      run: rake check:rubocop
+
+  Package:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: Package Build
+      run: yast-ci-ruby -o package
+
+  Yardoc:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: Yardoc
+      run: rake check:doc
+
+  # downloading the Docker image takes some time so bundling several fast
+  # checks into one job avoids that overhead
+  Checks:
+    runs-on: ubuntu-latest
+    container: registry.opensuse.org/yast/head/containers/yast-ruby:latest
+
+    steps:
+
+    - name: Git Checkout
+      uses: actions/checkout@v2
+
+    - name: POT Check
+      run: rake check:pot

README.md

@@ -1,5 +1,7 @@
 # YaST - The Proxy Configuration Module #
 
-[![Travis Build](https://travis-ci.org/yast/yast-proxy.svg?branch=master)](https://travis-ci.org/yast/yast-proxy)
-[![Jenkins Build](http://img.shields.io/jenkins/s/https/ci.opensuse.org/yast-proxy-master.svg)](https://ci.opensuse.org/view/Yast/job/yast-proxy-master/)
+[![Workflow Status](https://github.com/yast/yast-proxy/workflows/CI/badge.svg?branch=master)](
+https://github.com/yast/yast-proxy/actions?query=branch%3Amaster)
+[![Jenkins Status](https://ci.opensuse.org/buildStatus/icon?job=yast-yast-proxy-master)](
+https://ci.opensuse.org/view/Yast/job/yast-yast-proxy-master/)
 [![Coverage Status](https://img.shields.io/coveralls/yast/yast-proxy.svg)](https://coveralls.io/r/yast/yast-proxy?branch=master)

src/include/proxy/dialogs.rb

@@ -78,14 +78,6 @@ def initialize_proxy_dialogs(_include_target)
       ] # HTTP Version Not Supported
     end
 
-    # from OnlineUpdateDialogs.ycp
-    # Function opens the generic error dialog including the
-    # message with the [Details >>] button. It handles pressing
-    # the button itself.
-    #
-    # @param string message with the short error message
-    # @param string details with all of the error details
-
     def modified
       !(Proxy.http == @http && Proxy.ftp == @ftp && Proxy.no == @no &&
         Proxy.https == @https &&
@@ -94,6 +86,13 @@ def modified
         Proxy.enabled == @enabled)
     end
 
+    # from OnlineUpdateDialogs.ycp
+    # Function opens the generic error dialog including the
+    # message with the [Details >>] button. It handles pressing
+    # the button itself.
+    #
+    # @param [String] message with the short error message
+    # @param [String] details with all of the error details
     def ErrorPopupGeneric(message, details)
       # Informative label
       details = _("No details available.") if Builtins.size(details) == 0
@@ -366,7 +365,7 @@ def ReallyAbortCond
     end
 
     # Proxy dialog
-    # @param [Boolean] standalone true if not run from another ycp client
+    # @param [Boolean] _standalone true if not run from another ycp client
     # @return dialog result
     def ProxyMainDialog(_standalone)
       @enabled = Proxy.enabled

test/test_helper.rb

@@ -4,27 +4,41 @@
 
 require "yast/rspec"
 
+RSpec.configure do |config|
+  config.mock_with :rspec do |mocks|
+    # If you misremember a method name both in code and in tests,
+    # will save you.
+    # https://relishapp.com/rspec/rspec-mocks/v/3-0/docs/verifying-doubles/partial-doubles
+    #
+    # With graceful degradation for RSpec 2
+    mocks.verify_partial_doubles = true if mocks.respond_to?(:verify_partial_doubles=)
+  end
+end
+
 if ENV["COVERAGE"]
   require "simplecov"
-  SimpleCov.configure do
-    # Don't measure the tests themselves. We should have named them /spec/.
+  SimpleCov.start do
     add_filter "/test/"
   end
-  SimpleCov.start
 
-  # for coverage we need to load all ruby files
   src_location = File.expand_path("../src", __dir__)
-  # note that clients/ are excluded because they run too eagerly by design
-  Dir["#{src_location}/{include,lib,modules}/**/*.rb"].each do |f|
-    require_relative f
-  end
+  # track all ruby files under src
+  SimpleCov.track_files("#{src_location}/**/*.rb")
+
+  # additionally use the LCOV format for on-line code coverage reporting at CI
+  if ENV["CI"] || ENV["COVERAGE_LCOV"]
+    require "simplecov-lcov"
+
+    SimpleCov::Formatter::LcovFormatter.config do |c|
+      c.report_with_single_file = true
+      # this is the default Coveralls GitHub Action location
+      # https://github.com/marketplace/actions/coveralls-github-action
+      c.single_report_path = "coverage/lcov.info"
+    end
 
-  # use coveralls for on-line code coverage reporting at Travis CI
-  if ENV["TRAVIS"]
-    require "coveralls"
     SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
       SimpleCov::Formatter::HTMLFormatter,
-      Coveralls::SimpleCov::Formatter
+      SimpleCov::Formatter::LcovFormatter
     ]
   end
 end