Added flag to determine if the config should be written to the target system #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the to_target variable in order to determine if during the installation the proxy settings should be written in the target system or not (bsc#1185016)
teclator
changed the title
|
About the rubocop failure, I could do some cleanup but not sure if it worth it taken in account the use of this module. |
imobachgs
approved these changes
Jun 9, 2021
mvidner
reviewed
Jun 9, 2021
Co-authored-by: Martin Vidner <mvidner@suse.cz>
teclator
changed the title
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During installation or autoinstallation, the proxy configuration is written to the the inst-sys and then we have to decide if we should copy or write these settings to the target system or not.
Solution
The decision is currently made in case that the proxy configuration is given through linuxrc but it is ignored in case we are using only AutoYaST. So, two main options came to my mind.
1. Maintain the current check and force the use of proxy linuxrc parameter in case of AutoYaST.
2. Add a flag which will determine if we should write the config to the target system or not
Originally I checked if the variables that exported as environment variables were empty or not but in case that the configuration is read then the defaults could already had set the no_domains variable.
In this PR we have gone for option 2
see yast/yast-installation#965 && yast/yast-network#1231 && yast/yast-autoinstallation#767