Fix backtrace formatting in YPython::PyErrorHandler() [Merge SLE-15-SP3 into master] #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An exception value returned by PyErr_Fetch() can be in certain
situations "unnormalized", which means the value does not have to be an
instance of the returned exception type. This typically happens when an
exception is set from a native library. For instance:
> PyObject *w = Py_BuildValue("(i,i)", 123, 456);
> PyErr_SetObject(NativeError, w);
The exception value is in this case a tuple object and not an instance
of NativeError, until the exception gets normalized.
Code in YPython::PyErrorHandler() passes an obtained exception value
directly to traceback.format_exception(). This method however expects
that the value is already a valid exception object and fails quickly
with an AttributeError when that is not the case. This subsequently
results in an unhandled error in YPython::PyErrorHandler() and in a
SystemError when other Python/C API functions are invoked.
The patch fixes the problem by calling PyErr_NormalizeException() in
YPython::PyErrorHandler() to normalize the value to be an exception
object.
PyImport_ImportModule("traceback") in YPython::PyErrorHandler() returns
a new reference. Add a call to Py_XDECREF() once the code is done with
the module to avoid leaking its reference.
Fix backtrace formatting in YPython::PyErrorHandler()
Fix backtrace formatting in YPython::PyErrorHandler() (Merge SLE-15-SP2 into SLE-15-SP3)
This reverts commit b023478.
To have changes in sequence.
|
@petrpavlu I have created this one and closed #39 as commented at #39 (comment) Hope you don't mind. |
|
✔️ Public Jenkins job #24 successfully finished |
|
✔️ Internal Jenkins job #8 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #39 after #38 was merged. It basically