disable unavailable extensions (bnc#883148)

src/lib/registration/addon.rb

@@ -65,6 +65,7 @@ def create_addon_with_deps(root)
     # delegate methods to underlaying suse connect object
     def_delegators :@pure_addon,
       :arch,
+      :available,
       :description,
       :eula_url,
       :free,
@@ -110,6 +111,9 @@ def label
     def selectable?
       # Do not support unregister
       return false if registered?
+      # Do not select not available addons
+      # (explicitly check for false, it's reported only by SMT)
+      return false if addon.available == false
       # Do not allow to select child without selected or already registered parent
       return false if depends_on && !(depends_on.selected? || depends_on.registered?)
       # Do not allow to unselect parent if any children is selected

src/lib/registration/ui/addon_selection_dialog.rb

@@ -118,9 +118,14 @@ def addon_checkbox(addon, extra_spacing)
       end
 
       def addon_checkbox_element(addon)
+        # checkbox label for an unavailable extension
+        # (%s is an extension name)
+        label = (addon.available == false) ? (_("%s (not available)") % addon.label) :
+          label.addon
+
         CheckBox(Id(addon.identifier),
           Opt(:notify),
-          addon.label,
+          label,
           addon.selected? || addon.registered?)
       end
 

test/addon_spec.rb

@@ -151,6 +151,12 @@
       child.selected
       expect(parent.selectable?).to be_false
     end
+
+    it "returns false when the addon is not available" do
+      addon.available = true
+      expect(addon.selectable?).to be_false
+    end
+
   end
 
 end