Use id instead of name to track selected packages

src/lib/registration/package_search.rb

@@ -59,6 +59,7 @@ def packages
 
         remote_packages = pkg["products"].map do |product|
           RemotePackage.new(
+            id:      pkg["id"],
             name:    pkg["name"],
             version: pkg["version"],
             release: pkg["release"],

src/lib/registration/remote_package.rb

@@ -24,20 +24,24 @@ module Registration
   #
   # @example Find the status
   class RemotePackage
-    attr_reader :name, :arch, :version, :release, :addon
+    attr_reader :id, :name, :arch, :version, :release, :addon
 
+    # @param id      [Integer] Package ID
     # @param name    [String] Package name
     # @param arch    [String] Architecture
     # @param version [String] Version number
     # @param release [String] Release number
     # @param addon   [Addon]  Addon which the package belongs to
-    def initialize(name:, arch:, version:, release:, addon:)
+    # rubocop:disable Metrics/ParameterLists
+    def initialize(id:, name:, arch:, version:, release:, addon:)
+      @id = id
       @name = name
       @arch = arch
       @version = version
       @release = release
       @addon = addon
     end
+    # rubocop:enable Metrics/ParameterLists
 
     def full_version
       "#{version}-#{release}"

src/lib/registration/widgets/package_search.rb

@@ -143,9 +143,9 @@ def search_package(text)
         @search = ::Registration::PackageSearch.new(text: text)
         # TRANSLATORS: searching for packages
         Yast::Popup.Feedback(_("Searching..."), _("Searching for packages")) do
-          selected_package_names = selected_packages.map(&:name)
+          selected_package_ids = selected_packages.map(&:id)
           @search.packages.each do |pkg|
-            pkg.select! if selected_package_names.include?(pkg.name)
+            pkg.select! if selected_package_ids.include?(pkg.id)
           end
         end
         packages_table.change_items(@search.packages)
@@ -157,7 +157,8 @@ def search_package(text)
       # @return [RemotePackage,nil]
       def find_current_package
         return unless search && packages_table.value
-        search.packages.find { |p| p.name == packages_table.value }
+        selected_id = packages_table.value
+        search.packages.find { |p| p.id == selected_id }
       end
 
       # Selects/unselects the current package for installation

src/lib/registration/widgets/remote_packages_table.rb

@@ -52,19 +52,12 @@ def header
         ]
       end
 
-      # Returns the selected item
-      #
-      # @return [RemotePackage]
-      def selected_item
-        items.find { |i| i.name == value }
-      end
-
       # Updates the information for the given package
       #
       # @param item [RemotePackage] Package to update
       def update_item(item)
         columns_for_item(item).each_with_index do |content, idx|
-          change_cell(Id(item.name), idx, content)
+          change_cell(Id(item.id), idx, content)
         end
       end
 
@@ -73,7 +66,7 @@ def update_item(item)
       # @see https://www.rubydoc.info/github/yast/yast-yast2/CWM%2FTable
       def format_items(items)
         items.map do |item|
-          columns = [Id(item.name)] + columns_for_item(item)
+          columns = [Id(item.id)] + columns_for_item(item)
           Item(*columns)
         end
       end

test/registration/remote_package_test.rb

@@ -24,7 +24,7 @@
 describe Registration::RemotePackage do
   subject(:package) do
     described_class.new(
-      name: "foobar", arch: :x86_64, version: "1.0", release: "1", addon: nil
+      id: 1, name: "foobar", arch: :x86_64, version: "1.0", release: "1", addon: nil
     )
   end
 

test/registration/widgets/package_search_test.rb

@@ -27,8 +27,8 @@
 
   let(:packages_table) do
     instance_double(
-      Registration::Widgets::RemotePackagesTable, value: package.name, change_items: nil,
-      update_item: nil, selected_item: package
+      Registration::Widgets::RemotePackagesTable, value: package.id,
+      change_items: nil, update_item: nil
     )
   end
 
@@ -38,7 +38,7 @@
 
   let(:package) do
     instance_double(
-      Registration::RemotePackage, name: "gnome-desktop", addon: addon,
+      Registration::RemotePackage, id: 1, name: "gnome-desktop", addon: addon,
       selected?: false, select!: nil, installed?: installed?
     )
   end
@@ -108,7 +108,7 @@
       context "and the package is already selected" do
         let(:package) do
           instance_double(
-            Registration::RemotePackage, name: "gnome-desktop", addon: addon,
+            Registration::RemotePackage, id: 1, name: "gnome-desktop", addon: addon,
             selected?: true, unselect!: nil, installed?: false
           )
         end