Return more safety when no product is selected

src/lib/registration/registration.rb

@@ -191,6 +191,7 @@ def offline_migration_products(installed_products, target_base_product)
     # @see SUSE::Connect::Yast.list_installer_updates
     def get_updates_list
       product = SwMgmt.base_product_to_register
+      return [] unless product
       id = Yast::ProductFeatures.GetStringFeature("globals", "self_update_id")
       if !id.empty?
         log.info "Using self update id from control file #{id.inspect}"

src/lib/registration/sw_mgmt.rb

@@ -239,6 +239,8 @@ def self.base_product_to_register
       # use FAKE_BASE_PRODUCT just for debugging
       base_product = ENV["FAKE_BASE_PRODUCT"] ? FAKE_BASE_PRODUCT : find_base_product
 
+      return unless base_product
+
       # filter out not needed data
       product_info = {
         "name"         => base_product["name"],

test/registration_spec.rb

@@ -229,6 +229,11 @@
         .and_return(updates)
       expect(subject.get_updates_list).to eq(updates)
     end
+
+    it "returns an empty list if no base product is selected" do
+      allow(Registration::SwMgmt).to receive(:base_product_to_register).and_return(nil)
+      expect(subject.get_updates_list).to eq([])
+    end
   end
 
   describe "#synchronize_products" do

test/sw_mgmt_spec.rb

@@ -106,6 +106,12 @@
   end
 
   describe ".base_product_to_register" do
+    it "returns nil if not able to find a product" do
+      expect(subject).to receive(:find_base_product).and_return(nil)
+
+      expect(subject.base_product_to_register).to eq(nil)
+    end
+
     it "returns base product base version and release_type" do
       expect(subject).to(receive(:find_base_product)
         .and_return("name" => "SLES", "arch" => "x86_64",