Disable unavailable extensions (bnc#883148) #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,7 @@ def create_addon_with_deps(root) | |||
| # delegate methods to underlaying suse connect object | |||
| def_delegators :@pure_addon, | |||
| :arch, | |||
| :available, | |||
There was a problem hiding this comment.
I see there two checks for false. It have impression that nil is in fact available. I found quite confusing to see that available = nil in fact is available. I recommend to hide such logic into addon class like removing this delegator and instead have
def available?
# nil mean, that server do not report about availability, so we expect that all is available
!(@pure_addon.available == false)
end
and then later use intuitive things like unless available?
| expect(addon.selectable?).to be_false | ||
| end | ||
|
|
||
| it "returns true when the addon is available" do |
There was a problem hiding this comment.
I miss case with it "returns true when addon availability is not set" do to cover common case.
|
LGTM |
lslezak
added a commit
that referenced
this pull request
Jun 23, 2014
Disable unavailable extensions (bnc#883148)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.