Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Rubocop for coding style checks #177

Merged
merged 80 commits into from Dec 11, 2014
Merged

Use Rubocop for coding style checks #177

merged 80 commits into from Dec 11, 2014

Commits on Nov 19, 2014

  1. added auto generated .rubocop.yml file

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    76590c0 View commit details
    Browse the repository at this point in the history

  2. rubocop: fixed "Prefer double-quoted strings"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    4582699 View commit details
    Browse the repository at this point in the history

  3. rubocop: fixed "Prefer $LOAD_PATH over $:"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    21b3c3f View commit details
    Browse the repository at this point in the history

  4. rubocop: fixed "Surrounding space missing in default value assignment"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    fbb9245 View commit details
    Browse the repository at this point in the history

  5. rubocop: fixed "Use def with parentheses when there are parameters"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    2a4a14f View commit details
    Browse the repository at this point in the history

  6. rubocop: fixed "Missing space after #"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    d218b6f View commit details
    Browse the repository at this point in the history

  7. rubocop: fixed "Separate every 3 digits"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    aa81160 View commit details
    Browse the repository at this point in the history

  8. rubocop: fixed "Don't use parentheses around the condition"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    44356bb View commit details
    Browse the repository at this point in the history

  9. rubocop: fixed "Use proc instead of Proc.new"

    @lslezak
    lslezak committed Nov 19, 2014
    Copy the full SHA
    ca24d6c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2014

  1. rubocop: fixed "Redundant begin block"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    19bb8b4 View commit details
    Browse the repository at this point in the history

  2. rubocop: fixed "Space missing after comma"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    009b26d View commit details
    Browse the repository at this point in the history

  3. rubocop: fixed "File.exists? is deprecated in favor of File.exist?"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    c49c1ab View commit details
    Browse the repository at this point in the history

  4. rubocop: fixed "Unused block argument"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    a7318b6 View commit details
    Browse the repository at this point in the history

  5. rubocop: fixed "Hash#has_key? is deprecated in favor of Hash#key?"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    b57fa7a View commit details
    Browse the repository at this point in the history

  6. rubocop: fixed "Extra blank line"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    9284fc7 View commit details
    Browse the repository at this point in the history

  7. rubocop: fixed "Do not use parentheses for method calls with no argum… 

    …ents"
    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    8071e09 View commit details
    Browse the repository at this point in the history

  8. rubocop: fixed "Avoid the use of Perl-style backrefs"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    d9f836f View commit details
    Browse the repository at this point in the history

  9. rubocop: fixed "trailing blank lines"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    6e4e464 View commit details
    Browse the repository at this point in the history

  10. rubocop: fixed "trailing comma"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    bf95ab8 View commit details
    Browse the repository at this point in the history

  11. rubocop: fixed "Pass &:unregistered as an argument to each instead of… 

    … a block"
    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    89613a6 View commit details
    Browse the repository at this point in the history

  12. rubocop: fixed "Redundant return"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    93df345 View commit details
    Browse the repository at this point in the history

  13. rubocop: fixed "Surrounding space missing for operators"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    140f116 View commit details
    Browse the repository at this point in the history

  14. rubocop: fixed "Incorrect indentation"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    2376182 View commit details
    Browse the repository at this point in the history

  15. rubocop: set max. line length to 140

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    7643f75 View commit details
    Browse the repository at this point in the history

  16. rubocop: fixed "Keep a blank line before and after private"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    1e8fe1a View commit details
    Browse the repository at this point in the history

  17. rubocop: fixed "Extra empty lines"

    @lslezak
    lslezak committed Nov 20, 2014
    Copy the full SHA
    295dc92 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2014

  1. rubocop: fixed "Nil comparison"

    @lslezak
    lslezak committed Nov 21, 2014
    Copy the full SHA
    f0882e0 View commit details
    Browse the repository at this point in the history

  2. rubocop: fixed "Comparison of something with itself"

    @lslezak
    lslezak committed Nov 21, 2014
    Copy the full SHA
    f1380e4 View commit details
    Browse the repository at this point in the history

  3. rubocop: fixed "Style/TrivialAccessors" - allow predicates

    @lslezak
    lslezak committed Nov 21, 2014
    Copy the full SHA
    6f51960 View commit details
    Browse the repository at this point in the history

  4. rubocop: set Style/StringLiteralsInInterpolation to double_quotes

    @lslezak
    lslezak committed Nov 21, 2014
    Copy the full SHA
    cb728e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2014

  1. rubocop: fixed "(...) interpreted as grouped expression"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    7832b2e View commit details
    Browse the repository at this point in the history

  2. rubocop: fixed "Shadowing outer local variable"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    b538889 View commit details
    Browse the repository at this point in the history

  3. rubocop: fixed "Unused method argument"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    d14dc19 View commit details
    Browse the repository at this point in the history

  4. rubocop: fixed "Useless private access modifier"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    6c9ae76 View commit details
    Browse the repository at this point in the history

  5. rubocop: fixed "Useless assignment to variable"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    774a339 View commit details
    Browse the repository at this point in the history

  6. rubocop: fixed "Do not use :: for method calls"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    17c4b7c View commit details
    Browse the repository at this point in the history

  7. rubocop: fixed "Avoid rescuing the Exception class"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    bf7d703 View commit details
    Browse the repository at this point in the history

  8. rubocop: fixed "Use a guard clause"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    a765df7 View commit details
    Browse the repository at this point in the history

  9. rubocop: fixed "Use the new Ruby 1.9 hash syntax"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    942697a View commit details
    Browse the repository at this point in the history

  10. rubocop: fixed "Use \ instead of + to concatenate"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    c4a5ef9 View commit details
    Browse the repository at this point in the history

  11. rubocop: use "raise" instead of "fail"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    9b35987 View commit details
    Browse the repository at this point in the history

  12. rubocop: fixed "Inconsistent indentation"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    b56cb23 View commit details
    Browse the repository at this point in the history

  13. rubocop: fixed "Avoid multi-line ternary operator"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    7df6e1d View commit details
    Browse the repository at this point in the history

  14. rubocop: fixed "Use nested module/class definitions"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    69bfce7 View commit details
    Browse the repository at this point in the history

  15. rubocop: disable Style/AlignArray and Style/AlignHash checks

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    0faa8f1 View commit details
    Browse the repository at this point in the history

  16. rubocop: disabled Style/AlignParameters check

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    983de2c View commit details
    Browse the repository at this point in the history

  17. rubocop: fixed "Redundant curly braces around a hash parameter"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    1cca12b View commit details
    Browse the repository at this point in the history

  18. rubocop: fixed "Space missing to the left of {"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    577f9ff View commit details
    Browse the repository at this point in the history

  19. rubocop: fixed "Space missing inside block"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    fc712b4 View commit details
    Browse the repository at this point in the history

  20. rubocop: fixed "Space inside Hash"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    2f3275c View commit details
    Browse the repository at this point in the history

  21. rubocop: fixed "Trailing whitespace"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    212fe4c View commit details
    Browse the repository at this point in the history

  22. rubocop: fixed "Use leading dot"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    d54a4bc View commit details
    Browse the repository at this point in the history

  23. rubocop: fixed "Use the new lambda syntax"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    c28dd0e View commit details
    Browse the repository at this point in the history

  24. rubocop: no extra indentation for case

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    58417ac View commit details
    Browse the repository at this point in the history

  25. rubocop: fixed "Favor modifier while"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    1a164cf View commit details
    Browse the repository at this point in the history

  26. rubocop: fixed "Do not use do with multi-line while"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    56ef162 View commit details
    Browse the repository at this point in the history

  27. rubocop: fixed "Space inside square brackets"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    61a9c57 View commit details
    Browse the repository at this point in the history

  28. rubocop: disable Style/NegatedIf check 

    unless should used only in traling form
    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    cc0cfc8 View commit details
    Browse the repository at this point in the history

  29. rubocop: fixed "Favor modifier if usage when having a single-line body"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    b5629d8 View commit details
    Browse the repository at this point in the history

  30. rubocop: fixed "Favor until over while for negative conditions"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    a196659 View commit details
    Browse the repository at this point in the history

  31. rubocop: fixed "Annotation keywords"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    f30ed1d View commit details
    Browse the repository at this point in the history

  32. rubocop: disable Style/MultilineOperationIndentation check

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    0c59678 View commit details
    Browse the repository at this point in the history

  33. rubocop: fixed "Use next to skip iteration"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    dbe92c4 View commit details
    Browse the repository at this point in the history

  34. rubocop: disable code metrics checks 

    they need non-trivial code refactoring
    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    0298d2c View commit details
    Browse the repository at this point in the history

  35. rubocop: fixed "Use Kernel#loop with break"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    938d586 View commit details
    Browse the repository at this point in the history

  36. rubocop: remove generated header

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    8d8da56 View commit details
    Browse the repository at this point in the history

  37. run rubocop at Travis 

    run "rake check:pot" as well
    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    f730c2a View commit details
    Browse the repository at this point in the history

  38. rubocop: better nil comparison fix

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    194f20a View commit details
    Browse the repository at this point in the history

  39. rubocop: better "Comparison of something with itself" fix

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    159021d View commit details
    Browse the repository at this point in the history

  40. rubocop: enable and fix "Style/AlignHash" 

    use "table" style
    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    c6903ac View commit details
    Browse the repository at this point in the history

  41. rubocop: enable and fix "Style/MultilineOperationIndentation"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    3cbfa31 View commit details
    Browse the repository at this point in the history

  42. rubocop: enable and fix "Style/AlignArray"

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    6615cab View commit details
    Browse the repository at this point in the history

  43. rubocop: enable "Style/AlignParameters" 

    use "with_fixed_indentation" style
    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    4d002c3 View commit details
    Browse the repository at this point in the history

  44. rubocop: set max. line lenght to 100, fix the long lines

    @lslezak
    lslezak committed Nov 26, 2014
    Copy the full SHA
    61316d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2014

  1. rubocop: use the default for Style/NumericLiterals

    @lslezak
    lslezak committed Nov 27, 2014
    Copy the full SHA
    d6bf450 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2014

  1. rubocop: separated a common YaST style 

    Same content as for nfs-client
Once things stabilize it should move to devtools/buildtools.
    @mvidner
    mvidner committed Dec 11, 2014
    Copy the full SHA
    6f123eb View commit details
    Browse the repository at this point in the history

  2. rubocop: remove "Style/MultilineOperationIndentation" from the common… 

    … part

See also 3cbfa31
This commit makes Rubocop pass again while highlighting the difference
in style to nfs-client.
Hopefully we can agree on a common style soon.
    @mvidner
    mvidner committed Dec 11, 2014
    Copy the full SHA
    2d8612a View commit details
    Browse the repository at this point in the history

  3. rubocop pinned to version ~> 0.27.0 

    0.28.0 detects "Extra empty line detected at block body beginning."
which I don't want to deal with now. Or with Style/WhateverNewCheck
appears in 0.29.0.
    @mvidner
    mvidner committed Dec 11, 2014
    Copy the full SHA
    7ac5d64 View commit details
    Browse the repository at this point in the history

  4. Do use the &block parameter explicitly.

    @mvidner
    mvidner committed Dec 11, 2014
    Copy the full SHA
    5e87590 View commit details
    Browse the repository at this point in the history

  5. more informative parameter names

    @mvidner
    mvidner committed Dec 11, 2014
    Copy the full SHA
    338e5cf View commit details
    Browse the repository at this point in the history