Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style fix #275

Merged
merged 3 commits into from Aug 31, 2016
Merged

Style fix #275

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae5345a
use more robust check for installation style
jreidinger Aug 31, 2016
4c54c77
Changes
jreidinger Aug 31, 2016
703c96e
change from review
jreidinger Aug 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions package/yast2-registration.changes
View file
Open in desktop
@@ -1,3 +1,10 @@
-------------------------------------------------------------------
Wed Aug 31 09:10:41 UTC 2016 - jreidinger@suse.com

- more robust check for installation qss for dark theme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More robust check for installation dark theme sounds better to me...

(bnc#996258)
- 3.1.188

-------------------------------------------------------------------
Thu Aug 25 12:22:58 UTC 2016 - jreidinger@suse.com

Expand Down
2 changes: 1 addition & 1 deletion package/yast2-registration.spec
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@


Name: yast2-registration
Version: 3.1.187
Version: 3.1.188
Release: 0

BuildRoot: %{_tmppath}/%{name}-%{version}-build
Expand Down
3 changes: 2 additions & 1 deletion src/lib/registration/ui/addon_selection_base_dialog.rb
View file
Open in desktop
Expand Up @@ -150,7 +150,8 @@ def richtext_checkbox(id:, label:, selected:, enabled:, indented: false)
else
indent = " " * (indented ? 7 : 1)

installation = Yast::Stage.initial
# check for installation style, which is dark, FIXME: find better way
installation = ENV["Y2STYLE"] == "installation.qss"
image = (installation ? "inst:" : "normal:") +
(selected ? "on:" : "off:") + (enabled ? "enabled" : "disabled")
color = installation ? "white" : "black"
Expand Down