Fix registration #338
Merged
Fix registration #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
approved these changes
Oct 11, 2017
| next_addon = to_process.find do |addon| | ||
| addon.depends_on.nil? || !to_process.include?(addon.depends_on) | ||
| end | ||
| raise "circular dependencies found in addons #{to_process.inspect}" unless next_addon |
There was a problem hiding this comment.
Report.Error would be probably more user friendly, but hopefully this never happens so let's make it simple...
There was a problem hiding this comment.
Well, I hope we catch it quickly in openQA when this happen, so I hope not needed. Also Report is useless as result is that it won't work.
There was a problem hiding this comment.
The problem is that it might happen after the release, few months later... But anyway as this is really a corner case let's use this simple solution...
test/addon_spec.rb
Outdated
| @@ -78,6 +78,19 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe ".registration_order" do | |||
| it "returns in addons in order that allow registration" do | |||
There was a problem hiding this comment.
returns addons sorted in the registration order
package/yast2-registration.changes
Outdated
| @@ -1,4 +1,11 @@ | |||
| ------------------------------------------------------------------- | |||
| Wed Oct 11 08:49:16 UTC 2017 - jreidinger@suse.com | |||
|
|
|||
| - Fix registration when there is auto selected extensions | |||
There was a problem hiding this comment.
Fixed registration of autoselected extensions
lslezak
approved these changes
Oct 11, 2017
| next_addon = to_process.find do |addon| | ||
| addon.depends_on.nil? || !to_process.include?(addon.depends_on) | ||
| end | ||
| raise "circular dependencies found in addons #{to_process.inspect}" unless next_addon |
There was a problem hiding this comment.
The problem is that it might happen after the release, few months later... But anyway as this is really a corner case let's use this simple solution...
mvidner
added a commit
that referenced
this pull request
May 20, 2020
…c#1169577) In commit 1c7d041, PR #440 , the idea was that we can unselect an addon whose license was declined, and proceed with installing the remaining addons. But that does not work out with autoselected addons ( #335 #338 ) where we take into account the product dependencies. The new solution is to interpret a refusal of a license as the Abort button, which ends installation of ALL selected addons.
mvidner
added a commit
that referenced
this pull request
May 20, 2020
…c#1169577) Without this, an addon is still installed even if its license is declined. In commit 1c7d041, PR #440 , the idea was that we can unselect an addon whose license was declined, and proceed with installing the remaining addons. But that does not work out with autoselected addons ( #335 #338 ) where we take into account the product dependencies. The new solution is to interpret a refusal of a license as the Abort button, which ends installation of ALL selected addons.
mvidner
pushed a commit
that referenced
this pull request
May 22, 2020
…c#1169577) Without this, an addon is still installed even if its license is declined. In commit 1c7d041, PR #440 , the idea was that we can unselect an addon whose license was declined, and proceed with installing the remaining addons. But that does not work out with autoselected addons ( #335 #338 ) where we take into account the product dependencies. The new solution is to interpret a refusal of a license as the Back button, which ends installation of ALL selected addons.
mvidner
pushed a commit
that referenced
this pull request
May 28, 2020
…c#1169577) Without this, an addon is still installed even if its license is declined. In commit 1c7d041, PR #440 , the idea was that we can unselect an addon whose license was declined, and proceed with installing the remaining addons. But that does not work out with autoselected addons ( #335 #338 ) where we take into account the product dependencies. The new solution is to interpret a refusal of a license as the Back button, which ends installation of ALL selected addons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.