-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RegistrationCode widget: use always the the custom_url for registering #393
Conversation
teclator
commented
Aug 21, 2018
- https://bugzilla.suse.com/show_bug.cgi?id=1100199
return false if UrlHelpers.registration_url == :cancel | ||
|
||
registration = Registration.new(url) | ||
registration = Registration.new(options.custom_url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how is now handled cancel case? Will it still work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just worry if we do not break working scenario like registration on running system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong that was mainly for slp discovery but we are even not using it as we are always using the custom_url
return url if url == :cancel |
return custom_url if custom_url && !custom_url.empty? |
options.custom_url = default_url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current problem is that we are using always the cached url once obtained, other solution could be resetting the cached url before fetching it:
def self.reset_registration_url |