Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegistrationCode widget: use always the the custom_url for registering #393

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

teclator
Copy link
Contributor

@coveralls
Copy link

coveralls commented Aug 21, 2018

Coverage Status

Coverage increased (+0.03%) to 63.7% when pulling b978355 on bsc_1100199 into 3156431 on SLE-12-SP3.

return false if UrlHelpers.registration_url == :cancel

registration = Registration.new(url)
registration = Registration.new(options.custom_url)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so how is now handled cancel case? Will it still work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just worry if we do not break working scenario like registration on running system.

Copy link
Contributor Author

@teclator teclator Aug 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong that was mainly for slp discovery but we are even not using it as we are always using the custom_url

return url if url == :cancel

return custom_url if custom_url && !custom_url.empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current problem is that we are using always the cached url once obtained, other solution could be resetting the cached url before fetching it:

def self.reset_registration_url

@dgdavid dgdavid merged commit 5fa9ea5 into SLE-12-SP3 Oct 19, 2018
@dgdavid dgdavid deleted the bsc_1100199 branch October 19, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants