Sle 15 ga registration popup #402
Conversation
| "Without these media only a minimum system is available\n" \ | ||
| "in this installation.") % | ||
| { media_name: "SLE-15-Packages", download_url: "https://download.suse.com" } | ||
| if media_name && !media_name.empty? && |
There was a problem hiding this comment.
The nil check is actually not needed, ProductFeatures.GetStringFeature returns empty string if it is not found, see here. Just remove the media_name && download_url checks and add a comment describing that so it is clear.
| _("A full system can be installed using the\n" \ | ||
| "%{media_name} media from %{download_url}.") % | ||
| { media_name: media_name, download_url: download_url } | ||
| elsif media_name && !media_name.empty? |
There was a problem hiding this comment.
I'm thinking if handling of the other cases is needed for the future. It feels a bit like over engineering...
I think the additional medium will always have some name (even if a stupid one like DVD2), you need to be able to somehow tell the customers to use an additional medium and that's hard without a name. 😁
Maybe we could simply require defining both and drop these extra conditions. On the other hand this extra code is pretty small and straightforward so I'll leave the decision up to you. 😃
There was a problem hiding this comment.
I even do not have a testcase for that corner cases :-) --> removed.
No description provided.