Do not abort the installation when an addon EULA is refused #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
force-pushed
the
feature/bsc-1114018-not-abort-when-refuse-a-license
branch
from
5e9b416
to
683d405
Compare
dgdavid
force-pushed
the
feature/bsc-1114018-not-abort-when-refuse-a-license
branch
2 times, most recently
from
3cd3b8f
to
a8275e6
Compare
dgdavid
force-pushed
the
feature/bsc-1114018-not-abort-when-refuse-a-license
branch
from
a8275e6
to
2aad7cd
Compare
dgdavid
changed the title
dgdavid
force-pushed
the
feature/bsc-1114018-not-abort-when-refuse-a-license
branch
from
21e3271
to
e54b462
Compare
Which allows to extract those selected addons * that do not require an EULA acceptance * whose EULA were not refused
Allowing to refuse an EULA without aborting the installation. Simply do not set the EULA as accepted and do not register the addon later, as is explained in the message shown to the user before refuse the license.
Using a `case` statement instead of multiple/isolated `if`s.
Which will return the addons pending to be registered.
dgdavid
force-pushed
the
feature/bsc-1114018-not-abort-when-refuse-a-license
branch
2 times, most recently
from
343258f
to
9495a9a
Compare
This was referenced Jul 1, 2019
lslezak
approved these changes
Jul 1, 2019
Co-Authored-By: Ladislav Slezák <lslezak@suse.cz>
Just initializating the EULA acceptance to false.
Co-Authored-By: Ladislav Slezák <lslezak@suse.cz>
dgdavid
force-pushed
the
feature/bsc-1114018-not-abort-when-refuse-a-license
branch
from
9495a9a
to
efe319f
Compare
|
|
|
✔️ Internal Jenkins job #2 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When user refuses an addon's EULA (doing click in "Next" without check the I Agree to the License Terms.) the installation is completely aborted.
Solution
In spite of in the current code there is an intentional (and broken) behavior to
it seems that the correct behavior should be just go ahead refusing the license and not installing/registering the addon, according to the message shown to the user.
Show/hide screenshot
To do that, it has been necessary to update
yast2-packagertoo (see yast/yast-packager#452), in order to support "refuse" as a cancel action. Otherwise, it is not possible to distinguish when the "abort" means "to refuse the license agreement" or "abort the installation".Tests
Caveats
The selection is untouched. I.e., when a license is refused but the user goes back to the select extensions dialog, the product is still selected.