Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluating addon-list: Uses version without release for connecting SC… #500

Merged
merged 1 commit into from Jul 13, 2020
Merged

Evaluating addon-list: Uses version without release for connecting SC… #500

merged 1 commit into from Jul 13, 2020

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Jul 13, 2020 •
edited

…C (bsc#1162755).

Due this change
https://github.com/yast/yast-registration/pull/454/files#diff-8abb084e7b29d0f192dcc6ab937bc948R140

The call "old" base_product_to_register returns "version_version" for the version whereas the "new" call installed_base_product returns "version_release".

While an upgrade SCC will be given a version_release number now which seems to be wrong.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.016% when pulling ab96e2d on SLE-15-SP2-bsc-1162755 into 3da56d9 on SLE-15-SP2.

lslezak
lslezak approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@schubi2 schubi2 merged commit 8faa6e0 into SLE-15-SP2 Jul 13, 2020
@schubi2 schubi2 deleted the SLE-15-SP2-bsc-1162755 branch July 13, 2020 08:59
@schubi2 schubi2 mentioned this pull request Jul 13, 2020
Merged
schubi2 added a commit that referenced this pull request Jul 13, 2020
@schubi2
Evaluating addon-list: Uses version without release for connecting SC…
b7533f2 
…C (bsc#1162755). (#500) (#501)
imobachgs added a commit that referenced this pull request Jul 17, 2020
@imobachgs
Merge branch 'master' into export-suse-register
a1aa0ff 
* master:
  add comment about lazy loading
  update dependencies
  changes
  Evaluating addon-list: Uses version without release for connecting SCC (bsc#1162755). (#500) (#501)
  do not use directly profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schubi2 @coveralls @lslezak