Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests compatible with libsuseconnect #548

Merged
merged 1 commit into from Nov 30, 2021

Conversation

skazi0
Copy link
Contributor

@skazi0 skazi0 commented Nov 22, 2021

Most functions return generic OpenStruct instead of specialized classes.
Some features (only used in tests) are missing (e.g. Product.to_triplet).
Asserts related to internal implementation details were removed or
converted to higher level (e.g. File mocks).

@coveralls
Copy link

coveralls commented Nov 22, 2021

Coverage Status

Coverage decreased (-0.04%) to 84.563% when pulling 080ad0d on skazi0:connect-ng-test-updates into d4d8e6a on yast:master.

Most functions return generic OpenStruct instead of specialized classes.
Some features (only used in tests) are missing (e.g. Product.to_triplet).
Asserts related to internal implementation details were removed or
converted to higher level (e.g. File mocks).
@skazi0 skazi0 marked this pull request as ready for review November 29, 2021 15:15
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! 👍

@lslezak lslezak merged commit 54c0185 into yast:master Nov 30, 2021
@yast-bot
Copy link
Contributor

❌ Public Jenkins job #122 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants