Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New rspec-mocks distinguish between hash and keyword arguments passed to `with`. The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed. rspec-mocks 3.11.2 / 2022-10-25: > Bug Fixes: Support keyword argument semantics when constraining argument > expectations using with on Ruby 3.0+ with instance_double > rspec/rspec-mocks#1473
mvidner
force-pushed
the
rspec-kw-hash
branch
from
4b958f8
to
5b52161
Compare
jreidinger
reviewed
Oct 31, 2022
| expect(SUSE::Connect::YaST).to receive(:write_config).with( | ||
| url: url, | ||
| insecure: false | ||
| ) |
There was a problem hiding this comment.
well, I am not sure if old form is wrong as it is one of ruby feature to auto convert hash if it is only argument. But maybe lost with ruby3?
There was a problem hiding this comment.
Since Ruby 3 hashes and keyword arguments are distinct: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
jreidinger
approved these changes
Oct 31, 2022
1 task
|
✔️ Public Jenkins job #156 successfully finished |
|
✔️ Internal Jenkins job #112 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New rspec-mocks distinguish between hash and keyword arguments passed to
with.The tested code does use hashes but we've used keywords in tests because
it's shorter to write. Fixed.
rspec-mocks 3.11.2 / 2022-10-25:
Solution
Use hashes in tests instead of keywords
Testing
Screenshots
Not affected