Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL certificate generation #8

Merged
merged 18 commits into from
Apr 16, 2018
Merged

SSL certificate generation #8

merged 18 commits into from
Apr 16, 2018

Conversation

ikapelyukhin
Copy link
Contributor

@ikapelyukhin ikapelyukhin commented Mar 22, 2018 •
edited

Generated SSL files would be created in /usr/share/rmt/ssl/ directory.
The necessary changes for RMT are in this PR.

@coveralls
Copy link

coveralls commented Mar 26, 2018 •
edited

Pull Request Test Coverage Report for Build 109

  • 222 of 222 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 64: 0.0%
Covered Lines: 418
Relevant Lines: 418
💛 - Coveralls

ikapelyukhin
ikapelyukhin commented Mar 29, 2018
View reviewed changes
src/lib/rmt/utils.rb Outdated
@@ -61,7 +60,7 @@ def write_config_file(config)

end

# Runs a command and returns the exit code
# Runs a command and returns the has with exit code, stdout and stderr
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME: weird comment changes

@ikapelyukhin ikapelyukhin removed the wip label Apr 4, 2018
@ikapelyukhin
Copy link
Contributor Author

@digitaltom @wstephenson I've added the final setup page that just tells you that the setup has been finished successfully.
Also now the wizard will skip the DB setup step if valid DB credentials are found in the configuration file.

@digitaltom
Copy link
Collaborator

I think it would be useful to display the generated setup on the final page and not just output that the setup is complete.

For example display:

  • the used SCC credentials
  • the used database credentials
  • the location of the generated certificates
  • the location where RMT stores mirrored files
  • the location of the RMT config file

wstephenson
wstephenson approved these changes Apr 16, 2018
View reviewed changes
Copy link
Collaborator

@wstephenson wstephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ikapelyukhin ikapelyukhin merged commit 776591a into master Apr 16, 2018
@ikapelyukhin ikapelyukhin deleted the ssl_certificate_generation branch April 16, 2018 12:52
@ikapelyukhin
Copy link
Contributor Author

:neckbeard:

@ikapelyukhin ikapelyukhin mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wstephenson wstephenson wstephenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ikapelyukhin @coveralls @digitaltom @wstephenson