Run the libyui tests

package/yast2-ruby-bindings.spec

@@ -46,9 +46,9 @@ BuildRequires:  yast2-ycp-ui-bindings-devel >= 4.3.1
 # The test suite includes a regression test (std_streams_spec.rb) for a
 # libyui-ncurses bug fixed in 2.47.3
 BuildRequires:  libyui-ncurses >= 2.47.3
-# The mentioned test requires to check if tmux is there, because tmux is
-# needed to execute the test in headless systems
-BuildRequires:  which
+# The mentioned test requires tmux in order to be executed in headless systems
+# Also many other libyui tests to come
+BuildRequires:  tmux
 
 # only a soft dependency, the Ruby debugger is optional
 Suggests:       rubygem(%{rb_default_ruby_abi}:byebug)

tests/CMakeLists.txt

@@ -1,6 +1,11 @@
-#
-# CMakeLists.txt for yast2/ruby-bindings/tests/ruby
-#
+# CMakeLists.txt for yast-ruby-bindings/tests
+
+# use
+#   make test
+# or, for verbose output,
+#   make test ARGS=-V
+# ARGS is passed to ctest; see also
+#   man ctest
 
 ENABLE_TESTING()
 
@@ -12,3 +17,8 @@ endforeach(test)
 
 ADD_TEST("integration"  ruby ${CMAKE_CURRENT_SOURCE_DIR}/integration/run.rb)
 ADD_TEST("translations" rspec --format doc ${CMAKE_CURRENT_SOURCE_DIR}/integration/translations_spec.rb)
+
+file(GLOB libyui_tests "libyui/*.test")
+foreach(test ${libyui_tests})
+    ADD_TEST(${test} ${test})
+endforeach()

tests/libyui/README.md

@@ -1,3 +1,3 @@
 
-- `foo` - main script of the test case
+- `foo.test` - main script of the test case
 - `foo.rb` - UI set up

tests/libyui/table_sort_wrong_cell_1165388.rb

@@ -1,4 +1,14 @@
-#!/usr/sbin/yast
+#! /usr/bin/env ruby
+
+# See table_sort_wrong_cell_1165388.test
+
+require_relative "../test_helper"
+require "yast"
+
+if Yast.ui_component == ""
+  Yast.ui_component = ARGV[0] || "ncurses"
+end
+
 module Yast
   class TableCellClient < Client
     def main

tests/libyui/table_sort_wrong_cell_1165388 → tests/libyui/table_sort_wrong_cell_1165388.test

@@ -1,9 +1,17 @@
 #!/bin/sh
+
+# Verify that changing a value in a sorted table works correctly.
+# See https://bugzilla.opensuse.org/show_bug.cgi?id=1165388
+
 set -u                          # unset variables are an error
-. ../examples/screenshots-tui/scripts/tmux-uitest.sh
+MYDIR=$(dirname "$0")
+# shellcheck source=/dev/null # that file is checked separately
+. "$MYDIR"/tmux-uitest.sh
 BASE=table_sort_wrong_cell_1165388
 
-tmux_new_session /usr/sbin/yast ./"$BASE".rb || exit
+tmux_new_session "$MYDIR"/"$BASE".rb || exit
+trap tmux_cleanup EXIT
+
 tmux_await "Table sorting test" || exit
 sleep 0.1                       # draw the rest of the screen
 

tests/libyui/tmux-uitest.sh

@@ -1,5 +1,8 @@
+#!/bin/bash
+# tmux-uitest.sh - a shell library to test Text User Interface using tmux
+
 SESSION=uitest
-: ${VERBOSE=false}
+: "${VERBOSE=false}"
 
 # $@ commands
 tmux_new_session() {
@@ -18,15 +21,15 @@ tmux_new_session() {
 tmux_grep() {
     local REGEX="$1"
     tmux capture-pane -t "$SESSION" -p | grep -E --quiet "$REGEX"
-    RESULT=(${PIPESTATUS[@]})
+    RESULT=("${PIPESTATUS[@]}")
 
-    if [ ${RESULT[0]} != 0 ]; then
+    if [ "${RESULT[0]}" != 0 ]; then
         # capturing the pane failed; the session may have exited already
         return 2
     fi
 
     # capturing went fine, pass on the grep result
-    test ${RESULT[1]} = 0
+    test "${RESULT[1]}" = 0
 }
 
 # $1 regex (POSIX ERE) to find in captured pane
@@ -68,7 +71,13 @@ tmux_send_keys() {
     tmux send-keys -t "$SESSION" "$1"
 }
 
-# $1 session name
+# usage: trap tmux_cleanup EXIT
+tmux_cleanup() {
+    if tmux_has_session; then
+        tmux_kill_session
+    fi
+}
+
 # ret code: true or false
 tmux_has_session() {
     if $VERBOSE; then
@@ -79,7 +88,6 @@ tmux_has_session() {
 }
 
 
-# $1 session name
 tmux_kill_session() {
     if $VERBOSE; then
         echo Killing the session