Rubocop autocorrected: Style/SelfAssignment

yast · Jun 5, 2015 · af947b5 · af947b5
1 parent 8f585fa
commit af947b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -151,11 +151,6 @@ Style/Next:
 Style/OpMethod:
   Enabled: false
 
-# Offense count: 5
-# Cop supports --auto-correct.
-Style/SelfAssignment:
-  Enabled: false
-
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAsExpressionSeparator.

diff --git a/src/ruby/yast/builtins.rb b/src/ruby/yast/builtins.rb
@@ -1073,10 +1073,10 @@ def self.symmetric_difference(set1, set2)
           end
         end
         unless ss1.empty?
-          res = res + ss1.reverse
+          res += ss1.reverse
         end
         unless ss2.empty?
-          res = res + ss2.reverse
+          res += ss2.reverse
         end
         Yast.deep_copy(res.reverse)
       end
@@ -1130,10 +1130,10 @@ def self.union(set1, set2)
         end
 
         unless ss1.empty?
-          res = res + ss1.reverse
+          res += ss1.reverse
         end
         unless ss2.empty?
-          res = res + ss2.reverse
+          res += ss2.reverse
         end
 
         Yast.deep_copy(res.reverse)

diff --git a/src/ruby/yast/logger.rb b/src/ruby/yast/logger.rb
@@ -15,7 +15,7 @@ def y2_logger_helper(level,args)
         args.shift
         caller_frame = 2
       else
-        caller_frame = caller_frame + args.shift
+        caller_frame += args.shift
       end
     end