Fixed "Comparable#== will no more rescue exceptions of #<=>" (bsc#933470) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which triggers when tests are run as LANG=en_US rspec tests/ruby/*_spec.rb
| @@ -75,6 +71,10 @@ def term(*params) | |||
| it "if value is equal, then use params to comparison" do | |||
| expect(term(:HBox, "test")).to be > term(:HBox) | |||
| end | |||
|
|
|||
| it "if non-term, then uncomparable" do | |||
There was a problem hiding this comment.
maybe be specific like like then return nil?
|
Thanks for fixing, just two nitpickings. |
…470) Term and Path would raise exceptions when <=> was used to compare them with something that was not a Term or Path. In particular it happened during RSpec argument matching. In older Ruby core, Comparable#== would silently mask such exceptions, now it started producing warnings. https://bugs.ruby-lang.org/issues/7688
mvidner
force-pushed
the
comparable-spaceship
branch
from
6441ce8
to
04f4979
Compare
mvidner
added a commit
that referenced
this pull request
Jun 3, 2015
Fixed "Comparable#== will no more rescue exceptions of #<=>" (bsc#933470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.suse.com/show_bug.cgi?id=933470
Term and Path would raise exceptions when <=> was used to compare them
with something that was not a Term or Path.
In particular it happened during RSpec argument matching.
In older Ruby core, Comparable#== would silently mask such exceptions,
now it started producing warnings.
https://bugs.ruby-lang.org/issues/7688