Fix cli #198
Merged
Fix cli #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change require a bit longer explanantion. The bug is result of two changes. The first one is switch to ruby script as start point of YaST. The second one is bug mentioning that there is different title after this change. I found that the second one is caused by work-around in libyui which no longer works. So I decide to do it properly and always set proper title when starting YaST. And here it hits a bug. UI in YaST is lazy loaded, it means that it is created when first call to UI namespace happen. And setting title is that first UI call, so it creates UI even when command line is required. So this change change title only if there are no arguments for client. So module is showed in UI.
imobachgs
approved these changes
May 2, 2017
|
It seems that the change does not what it was expected to do, see https://bugzilla.suse.com/show_bug.cgi?id=1037891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please see commit message in c5c6b67 for explanation