[WIP] Don't crash on NoMethodError when Perl is involved #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Oct 4, 2020
| end | ||
|
|
||
| publish variable: :exception, type: "map" | ||
| end |
There was a problem hiding this comment.
In general change looks OK for me, I just miss more documentation in this module. Especially use cases ( exceptions when calling ruby code from non-ruby parts (includes e.g. also pkg bindings) ), how that variable exception looks like and who can set it. And maybe a paragraph in readme would make sense to point to this.
|
lets convert it to draft as it is still WIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the YCP component system, an exception can make YaST segfault.
This removes the segfault and replaces it with a
niliny2log:-/Further fixes, to propagate exceptions across Perl-Ruby border crossings, are desirable.
TODO: retarget this to SLE15-GA?