Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging all available products information into directory /var/log/Ya… #267

Closed
wants to merge 3 commits into from

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Feb 1, 2021

…ST2/product_info after YaST has crashed.


# Logging all information about the product evaluation
Yast.import "ProductEvaluation"
ProductEvaluation.write("internal_error")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also write some message into the file describing the problem:

Suggested change
ProductEvaluation.write("internal_error")
ProductEvaluation.write("internal_error", { error: "Exception raised in #{client}",
error_details: msg, error_backtrace: e.backtrace })

Just simply merge the optional extra keys passed to the function.

@lslezak
Copy link
Member

lslezak commented May 24, 2021

Actually I'm not sure if we should write the file in the global exception handler. The problem is that it might be triggered also in installed system, the required file might be missing, etc...

It can potentially trigger some more problems. I'd close it, let see if we really need something like this...

@lslezak lslezak closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants