Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby3 #279

Merged
merged 2 commits into from Nov 29, 2021
Merged

Ruby3 #279

merged 2 commits into from Nov 29, 2021

Conversation

jreidinger
Copy link
Member

Issue: ruby 3.0 produce warning:

/home/abuild/rpmbuild/BUILD/yast2-ruby-bindings-4.4.4/src/ruby/yast/ui.rb:4: warning: finalizer references object to be finalized

Fix:
store reference early, so it does not warn when it is finalized

lslezak
lslezak approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit 20f94d2 into master Nov 29, 2021
@jreidinger jreidinger deleted the ruby3 branch November 29, 2021 15:46
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #55 successfully finished
✔️ Created OBS submit request #934590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jreidinger @yast-bot @lslezak