Rubocop manual fix: Lint/UselessAssignment

yast · Apr 21, 2017 · c5e7061 · c5e7061
1 parent de6c48d
commit c5e7061
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 16 deletions.
diff --git a/src/clients/xpram.rb b/src/clients/xpram.rb
@@ -145,7 +145,6 @@ def XpramEnableHandler(options)
     # @param [Hash] options  a list of parameters passed as args
     # @return [Boolean] true on success
     def XpramDisableHandler(options)
-      options = deep_copy(options)
       if Xpram.start
         Xpram.start = false
         Xpram.modified = true

diff --git a/src/include/s390/dump/ui.rb b/src/include/s390/dump/ui.rb
@@ -185,8 +185,6 @@ def DumpDialog
           if Builtins.size(device) == 0
             Popup.Notify(_("You haven't selected any device."))
           else
-            # count devices for proper grammatical number output
-            num_devices = Builtins.size(Builtins.splitstring(device, " "))
             # warn only in case of force
             if !force ||
                 Popup.YesNo(

diff --git a/src/include/s390/iucvterminal-server/ui.rb b/src/include/s390/iucvterminal-server/ui.rb
@@ -579,7 +579,6 @@ def TsGroupDialogContent
 
     def MainDialogContent
       # draw active tab
-      widgets = nil
       widgets = if @current_main_tab == :t_zvmids
         ZvmIdsDialogContent()
       elsif @current_main_tab == :t_tsshell
@@ -726,7 +725,6 @@ def CommitTsUserDialogSettings
           from: "any",
           to:   "list <string>"
         )
-        groups = Builtins.mergestring(grouplist, ",")
         groupmap = Builtins.listmap(grouplist) { |g| { g => "1" } }
 
         force_pw_change = Convert.to_boolean(
@@ -823,10 +821,6 @@ def CommitTsGroupDialogSettings
         # check if the group should be added and  was not already used for TS auth
         if !Builtins.haskey(@ts_member_conf, identification)
           if is_ts_auth_group
-            group_members = Builtins.mergestring(userlist, ",")
-            group = Users.GetGroupByName(groupname, "")
-            gid = Ops.get_string(group, "gidNumber", "")
-
             # add ts_member_conf
             @ts_member_conf = Builtins.add(
               @ts_member_conf,
@@ -840,7 +834,6 @@ def CommitTsGroupDialogSettings
         else
           # delete group entry if disabled
           if !is_ts_auth_group
-            i = 0
             @ts_member_conf = Builtins.remove(@ts_member_conf, identification)
           end
         end
@@ -1626,7 +1619,6 @@ def IUCVTerminalServerDialog
     # The whole sequence
     # @return sequence result
     def IUCVTerminalServerSequence
-      ret = nil
       Wizard.CreateDialog
       Wizard.SetDesktopIcon("iucvterminal-server")
       IUCVTerminalServer.Read

diff --git a/src/modules/DASDController.rb b/src/modules/DASDController.rb
@@ -711,7 +711,6 @@ def FormatDisks(disks_list, par)
           end
         end
         index = 0
-        siz = Builtins.size(this_step)
         Builtins.foreach(this_step) do |k, _v|
           UI.ChangeWidget(
             Id(index),

diff --git a/src/modules/Dump.rb b/src/modules/Dump.rb
@@ -142,7 +142,6 @@ def FormatDisk(dev, force)
       Progress.NextStage
 
       if ret != 0
-        err = ""
         err = if ret == 11
           # error description
           _("Invalid or unusable disk (fatal).")

diff --git a/src/modules/IUCVTerminal.rb b/src/modules/IUCVTerminal.rb
@@ -97,7 +97,7 @@ def get_iucv_name
         match = entry.scan(/^#{@IUCV_PREFIX}@(.+)0\.service$/).first
         name = match.first if match
       end
-      name ||= @iucv_name
+      name || @iucv_name
     end
 
     def setup_iucv(target_num)

diff --git a/src/modules/IUCVTerminalServer.rb b/src/modules/IUCVTerminalServer.rb
@@ -445,7 +445,6 @@ def Read
           end
         end
       end
-      test = []
 
       Progress.NextStage
       true

diff --git a/src/modules/Xpram.rb b/src/modules/Xpram.rb
@@ -98,7 +98,6 @@ def Write
       # Xpram read dialog caption
       caption = _("Saving XPRAM Configuration")
       steps = 2
-      bret = true
 
       Progress.New(
         caption,